Fix bounds check for ImageDrawRectangleRec
#3732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having originally having issues with image drawing functions causing memory corruptions, I found that the condition for the bounds check in
ImageDrawRectangleRec
misses cases near the edges of theImage
. I used code like this, running with valgrind, to verify that the memory corruption no longer occurs: (sorry for the mess)I also implemented the additional suggestion from (#3721) and verified that extra pixels are no longer drawn at the edge of the image.