Added missing interpolation types for GLTF animation channels #3919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the GLTF animation loading only supported linear interpolation, so by adding support for
cgltf_interpolation_type_step
andcgltf_interpolation_type_cubic_spline
this should cover most cases.This was tested using
robot.gltf
by importing it into Blender, removing some keyframes, using constant and bezier interpolation, and then rerunning themodels_loading_gltf.exe
example. Step is easy to recognize, and I think the spline looks right as well, but I would love someone with discerning eyes to tell me if it looks accurate.Here's videos of the exact same animation timeline with different interpolation applied:
2024-04-15.01-40-29.mp4
2024-04-15.01-42-00.mp4
2024-04-15.01-42-36.mp4