Implementing GetMonitorWidth/Height for DRM

[gabriel-marques]

Hello :)

I would like to propose an implementation for the following functions for the DRM platform :

• int GetMonitorWidth(int monitor)
• int GetMonitorHeight(int monitor)
• int GetMonitorPhysicalWidth(int monitor)
• int GetMonitorPhysicalHeight(int monitor)
• const char *GetMonitorName(int monitor)

Although the monitor selection is not supported for the drm platform I kept the argument to avoid having multiple function prototypes.

I hope it complies to your coding rules :)

[colesnicov]

Hello. What would it be good for? In addition to the fact that I can find out these dimensions... At the moment we have encountered such an unpleasant dilemma regarding DRM: #3946. Can you please tell me about it?

[orcmid]

In GetMonitorName(int monitor)

for consistent behavior with the unimplemented case, you should use

const char name = "";

Also, you might want to do something about the non-zero value case, providing something like "unknown" or "unavailable". This will also avoid compiler warnings about monitor not being used :).

It looks like it might be valuable to have a GetMonitorCount() or similar as part of raylib.h and have that always return 1 for DRM.

Isn't there a raylib.h way to GetCurrentMonitor() or something like that? (I am being lazy.)

[colesnicov]

I dont know yet. I just tuk here for few days. tests, tests, tests...

[gabriel-marques]

Hello @orcmid :)

Thanks for the suggested changes of consistency, I will apply them :)
By the way, there is both GetMonitorCount() and GetCurrentMonitor() which although log that they are not implemented, returns the correct value (because the actual implementation is limited to one screen only)

// Get number of monitors
int GetMonitorCount(void)
{
    TRACELOG(LOG_WARNING, "GetMonitorCount() not implemented on target platform");
    return 1;
}

// Get number of monitors
int GetCurrentMonitor(void)
{
    TRACELOG(LOG_WARNING, "GetCurrentMonitor() not implemented on target platform");
    return 0;
}

[raysan5]

@gabriel-marques Implementation looks good to me. Please, let me know when this PR is ready for merging!

[gabriel-marques]

Hello,

As @orcmid suggested I changed the getMonitorName to return "" as default and also I changed others functions to also evaluate negative monitors.

[raysan5]

@gabriel-marques Thanks! Implementation looks good to me! Merging!