Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Fix examples not building with gestures system disabled #4020

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

Sprixitite
Copy link
Contributor

@Sprixitite Sprixitite commented May 31, 2024

Build no longer fails with -DSUPPORT_GESTURES_SYSTEM=OFF and -DBUILD_EXAMPLES=ON

Build no longer fails with -DSUPPORT_GESTURES_SYSTEM=OFF and -DBUILD_EXAMPLES=ON
@raysan5
Copy link
Owner

raysan5 commented May 31, 2024

@Sprixitite I don't understand this PR, why do those examples fail on compile if that flag is enabled? It should never happen.

@raysan5 raysan5 changed the title Fix examples not building with gestures system disabled [build] Fix examples not building with gestures system disabled May 31, 2024
@Sprixitite
Copy link
Contributor Author

When attempting to build with CMake (3.27.2) on Pop!_OS 22.04 running the commands:

mkdir build && cd build
cmake .. -DCUSTOMIZE_BUILD=ON -DSUPPORT_GESTURES_SYSTEM=OFF && make

Fails with linker errors when linking the relevant examples, as rgestures.h is not included due to the build option

@raysan5 raysan5 merged commit e74d13e into raysan5:master Jun 6, 2024
@raysan5
Copy link
Owner

raysan5 commented Jun 6, 2024

@Sprixitite Merging, thanks for the review!

JayLCypher pushed a commit to JayLCypher/raylib that referenced this pull request Jun 9, 2024
Build no longer fails with -DSUPPORT_GESTURES_SYSTEM=OFF and -DBUILD_EXAMPLES=ON
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants