Add an assert on custom frame control support #4444
Conversation
| @@ -27,12 +27,20 @@ | |||
| ********************************************************************************************/ | |||
|
|
|||
| #include "raylib.h" | |||
| #include "config.h" | |||
| #include "assert.h" | |||
There was a problem hiding this comment.
Since this is a system header it should use <> not ""
| #if !defined(SUPPORT_CUSTOM_FRAME_CONTROL) | ||
| // This examaple requires the SUPPORT_CUSTOM_FRAME_CONTROL feature. | ||
| // Please edit your raylib config.h and recompile raylib. | ||
| assert(false); | ||
| #endif |
There was a problem hiding this comment.
Why is assert needed? would not a printf and return -1 here be the same?
assert is not used any other raylib code.
There was a problem hiding this comment.
Inside the library assert might be to harsh,
but considering this example application can not function without that define, I would use an assert.
But whatever the codebase follows is fine for me
|
@Mercotui thanks but I'm not adding two extra libraries and an assert just because the user can not read the example instructions. |
|
Naja as I personally experienced: The whole screen flashes black and white at a high framerate. As for libraries: Anyway I could update the code to |
This prevents users from getting a attacked by angry frames when they try this example without reading the warnings in the source code.