V0.8.1 buildfix #428
Merged
V0.8.1 buildfix #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cython 3.0 release introduces breaking changes. Pin to earlier Cython until the code has been updated for compatibility. Make a new post1 release of this so downstream packages will pick up the working version of 0.8.1.
When installing with pip or PyPA's `build` utility, , the `-j` option for parallel builds is not passed by default. This increases the build time on systems where wheels need to be built, e.g. for releases or on systems where no pre-built wheel is available. This commit introduces a modified `build_ext` command which by default parallelises over all available CPUs, with an optional override using the `RAYSECT_BUILD_JOBS` environment variable if for any reason the number of build processes needs to be controlled manually.
|
Manylinux wheels built from this PR are available on TestPyPI: https://test.pypi.org/project/raysect/0.8.1.post1. Wheels are available for Python 3.7 through to 3.12, and there is also an sdist which can be downloaded and installed manually to verify it installs without error. I've tested all 6 Python versions in virtual environments: the wheel installs fine and all unit tests pass. I've also tested the sdist on Python 3.12, and again it builds and passes all unit tests without error. |
CnlPepper
approved these changes
Dec 14, 2023
Wheels for Python 3.7 to 3.9 can be built using manylinux2010, as there are binary wheels of oldest-supported-numpy available for these versions. For 3.10 onwards manylinux2014 is required for numpy binary wheels. Building numpy from source in the manylinux containers is not viable. There are now two scripts, one for each manylinux version, which will build wheels for all upstream-supported Python versions. These can be run as-is: info is in the first few lines of these files. Also, the dev notes on building wheels wtih manylinux have been updated to reference these files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cython 3.0 release introduces breaking changes. Pin to earlier Cython until the code has been updated for compatibility.
Make a new post1 release of this so downstream packages will pick up the working version of 0.8.1.
Also switch from Travis to Github actions to ensure builds are still error free.
Added a small snippet of code to get pip and PyPA build to use multiple CPUs to build this wheel by default, which greatly speeds up building release wheels. This is inspired by a similar addition which was made to Cherab.