Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: loading state and tooltip for specific dates in calendar component #166

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

mahakmakharia
Copy link
Contributor

adds loadingData prop to show Skeleton in the month grid if we load data asynchronously.
image

adds an option to show tooltips for specific dates
image

@mahakmakharia mahakmakharia requested a review from rsbh October 25, 2024 15:03
Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apsara ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 3:03pm

@rsbh rsbh merged commit 8277062 into main Oct 28, 2024
2 checks passed
@rsbh rsbh deleted the feat/tooltip-loader-calendar branch October 28, 2024 06:56
packages/raystack/calendar/calendar.tsx Show resolved Hide resolved
export type CalendarProps = DayPickerProps & OnDropdownOpen;
interface CalendarPropsExtended {
showTooltip?: boolean;
tooltipMessages?: { [key: string]: any };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kept the type open so that we can pass any relevant value for the message

packages/raystack/calendar/calendar.tsx Show resolved Hide resolved
packages/raystack/calendar/calendar.tsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants