fix: Adding service provider configuration files to fix the grpc sink… #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exception "Could not find policy 'pick_first'"
In the current implementation, the gRPC client chooses default LoadBalancerProvider ('pick_first') and default NameResolverProvider(DNS). The implementation classes PickFirstLoadBalancerProvider and DnsNameResolverProvider respectively are missing.
We can handle the issue with the including implementation classes through service provider configuration files.
* SPI io.grpc.LoadBalancerProvider: io.grpc.internal.PickFirstLoadBalancerProvider
* SPI io.grpc.NameResolverProvider: io.grpc.internal.DnsNameResolverProvider
lavkesh
pushed a commit
that referenced
this pull request
Nov 22, 2022
… exception "Could not find policy 'pick_first'" (#203) In the current implementation, the gRPC client chooses default LoadBalancerProvider ('pick_first') and default NameResolverProvider(DNS). The implementation classes PickFirstLoadBalancerProvider and DnsNameResolverProvider respectively are missing. We can handle the issue with the including implementation classes through service provider configuration files. * SPI io.grpc.LoadBalancerProvider: io.grpc.internal.PickFirstLoadBalancerProvider * SPI io.grpc.NameResolverProvider: io.grpc.internal.DnsNameResolverProvider Co-authored-by: Shreyansh <shreyansh.sangolli@gojek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… exception "Could not find policy 'pick_first'". Issue number here.
In the current implementation, the gRPC client chooses default LoadBalancerProvider ('pick_first') and default NameResolverProvider(DNS). The implementation classes PickFirstLoadBalancerProvider and DnsNameResolverProvider respectively are missing.
We can handle the issue with the including implementation classes through service provider configuration files.
Hey, I just made a Pull Request!
Please describe what you added, and add a screenshot if possible.
faster.
That makes it easier to understand the change so we can
✔️ Checklist