feat: add http delete method #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/docs/reference/faq.md
Outdated
| @@ -481,7 +481,7 @@ configs mean, please have a look at the config section. | |||
|
|
|||
| #### Does it support DELETE calls? | |||
|
|
|||
| At the moment, the HTTP Sink supports only PUT, POST and PATCH methods. | |||
| Yes, the HTTP Sink now supports DELETE calls also. | |||
There was a problem hiding this comment.
i don't think we need to mention now. we can remove now or mention it supports delete call from firehose version x.x.x
There was a problem hiding this comment.
also since this is a new feature, we need to bump up the firehose version
There was a problem hiding this comment.
fixed it mas
jesrypandawa
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.