feat: emit audit event+webhook when user is removed from a group #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 9464981920Details
💛 - Coveralls |
kushsharma
reviewed
Jun 12, 2024
kushsharma
reviewed
Jun 12, 2024
Pull Request Test Coverage Report for Build 9477509847Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9477836973Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
kushsharma
approved these changes
Jun 13, 2024
anujk14
added a commit
that referenced
this pull request
Jun 14, 2024
* feat: emit audit event+webhook when user is removed from a group * emit event as soon as relation is deleted * fix: send group org id instead of platform org id in user removal event
anujk14
added a commit
that referenced
this pull request
Jun 18, 2024
…#646) * feat: add audit log event for group deletion * move audit event for user removal to service * emit event on disabling org * feat: emit audit event+webhook when user is removed from a group (#640) * feat: emit audit event+webhook when user is removed from a group * emit event as soon as relation is deleted * fix: send group org id instead of platform org id in user removal event * feat(admin_ui): add filter, loader and sorting to the tables (#643) * chore: update apsara version * refactor: remove loading check from column definitions * refactor: remove loading check from roles and user table * refactor: remove loading check from billing list * refactor: remove loading check from groups list * refactor: remove loading check from projects list * refactor: remove loading check from users list * refactor: remove loading check from products list * refactor: remove loading check from preferences list * refactor: remove loading check and add filter in invoices list * fix(admin_ui): type mismatch in apsara datatable (#644) * ci: set goreleaser to v1 (#645) * trigger audit event after relation and repository have both been updated --------- Co-authored-by: Rishabh Mishra <me@rsbh.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We require a webhook which notifies downstream services about removal of user from groups. This PR introduces that into the service.
The reason for doing this in service is so that this event is triggered even if different handlers are used to perform this action.
The idea behind adding this instead of adding more and more information into policy events is to provide an easy to understand event to downstream services so that appropriate action can be taken by them. A few more events such as this will be introduced in subsequent PRs.