Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide descriptive debugging info on lint #308

Merged
merged 14 commits into from
Feb 11, 2022
Merged

Conversation

scortier
Copy link
Member

@scortier scortier commented Feb 2, 2022

Debugging Information on lint cmd -

Able to detect exact line number :

  • When user provide correct key part in Recipe (without grammar error)

Unable to detect exact line number :

  • When key part in recipe is incorrectly passed ( grammar mistake)
  • When the user forget to provide required config of plugins.

Example Preview :

recipe.yaml

1. name: kafkaToColumbus
2. source:
3.   name: kafka
4.   config:
5.     brok:
6.     label:
7. sinks:
8.   - name: columbus
9.     config:
10.       host:
11.       test:
12.   - name: xyz
13.   - name: console

Output:

image

@scortier scortier marked this pull request as draft February 2, 2022 07:23
@scortier scortier linked an issue Feb 8, 2022 that may be closed by this pull request
@scortier scortier self-assigned this Feb 8, 2022
@scortier scortier marked this pull request as ready for review February 8, 2022 08:25
cmd/lint.go Outdated Show resolved Hide resolved
recipe/recipe.go Show resolved Hide resolved
recipe/node.go Show resolved Hide resolved
utils/config.go Outdated Show resolved Hide resolved
cmd/lint.go Outdated Show resolved Hide resolved
cmd/lint.go Outdated Show resolved Hide resolved
recipe/node.go Outdated Show resolved Hide resolved
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ravisuhag ravisuhag merged commit 58bd4ea into main Feb 11, 2022
@ravisuhag ravisuhag deleted the chore_lint-info branch February 11, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide descriptive debugging info on lint
4 participants