What is the correct place to put Google Adsense code? #673

ArvindRSingh · 2022-08-22T09:09:45Z

ArvindRSingh
Aug 22, 2022

The Google AdSense suggests adding code in the <HEAD> but HBS adds it at the end of the <BODY>.
Maybe Google has changed the place to add code for new enrollments.

After adding googleAdsense in params.yaml the AdSense coded is added at the end as part of the body.

<html>
<body>
<!--StartFragment-->

<script data-ad-client=ca-pub-345345345 async src=https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js></script><script>'serviceWorker'in navigator&&window.addEventListener('load',()=>{navigator.serviceWorker.register('https://semicolon.today/service-worker.min.js').then(function(a){console.log('Successfully registered service worker',a)}).catch(function(a){console.warn('Error whilst registering service worker',a)})})</script>
--
  | </body>
  | </html>

<!--EndFragment-->
</body>
</html>

This is what Google suggests

Concern

As Google AdSense expects code in <HEAD> it might reject the enrollment.

Should this be changed in the HBS code, or is my finding wrong?

Answered by razonyang

Aug 23, 2022

@ArvindRSingh BTW, the Google AdSense script seems doesn't work well with service worker cache(unable to load), I suggest upgrading theme to latest commit which won't cache third-party scripts.

View full answer

razonyang · 2022-08-22T10:57:13Z

razonyang
Aug 22, 2022
Maintainer

Let's follow the suggestion of Google AdSense, it shouldn't a problem, since the script has async attribute.

See #674.

1 reply

razonyang Aug 23, 2022
Maintainer

@ArvindRSingh BTW, the Google AdSense script seems doesn't work well with service worker cache(unable to load), I suggest upgrading theme to latest commit which won't cache third-party scripts.

Answer selected by ArvindRSingh

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

What is the correct place to put Google Adsense code? #673

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 1 comment 1 reply

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Select a reply

What is the correct place to put Google Adsense code? #673

ArvindRSingh Aug 22, 2022

Concern

Replies: 1 comment · 1 reply

razonyang Aug 22, 2022 Maintainer

razonyang Aug 23, 2022 Maintainer

ArvindRSingh
Aug 22, 2022

Replies: 1 comment 1 reply

razonyang
Aug 22, 2022
Maintainer

razonyang Aug 23, 2022
Maintainer