Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect table of contents count #619

Closed
nemu1113 opened this issue Jul 24, 2022 · 3 comments · Fixed by #620
Closed

Incorrect table of contents count #619

nemu1113 opened this issue Jul 24, 2022 · 3 comments · Fixed by #620
Labels
bug Something isn't working

Comments

@nemu1113
Copy link
Contributor

I have discovered that the numbers displayed in the heading tags of this site template are not calculated correctly.

The calculation of the numbers was implemented in SCSS, so I looked into it in detail and found the following bug, which I would appreciate your fixing.

Target file
/assets/main/scss/post/index.scss
→L91

Before: "counter-reset: h#{$heading + 1}counter;"
After: "counter-reset: h#{$heading + 1}Counter;"

I have confirmed that the correct numbers were displayed after a simple modification of the SCSS and testing on a sample site.

I would be happy if I could contribute to your HBS template improvement.

@razonyang
Copy link
Owner

razonyang commented Jul 24, 2022

Oh, I didn't notice that, it may be a format tool issue, PR are welcome.

@razonyang razonyang added the bug Something isn't working label Jul 24, 2022
@razonyang
Copy link
Owner

@nemu1113 would you mind creating a pull request? I can do it for you, but I need your email address, so that I can mark this contributed by you.

nemu1113 added a commit to nemu1113/hugo-theme-bootstrap that referenced this issue Jul 24, 2022
Fix: Incorrect table of contents count razonyang#619
razonyang#619 (comment)
@nemu1113
Copy link
Contributor Author

@nemu1113 would you mind creating a pull request? I can do it for you, but I need your email address, so that I can mark this contributed by you.

@razonyang Thank you for your consideration.
Please check the pull request and merge if there are no problems.

example:
https://deploy-preview-620--hbs-docs.netlify.app/en/docs/image-processing/

before:
https://hbs.razonyang.com/v1/en/docs/image-processing/

razonyang pushed a commit to nemu1113/hugo-theme-bootstrap that referenced this issue Jul 25, 2022
razonyang pushed a commit that referenced this issue Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants