Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Viewer.js instead of built-in image viewer #240

Merged
merged 2 commits into from
Oct 24, 2021

Conversation

razonyang
Copy link
Owner

No description provided.

@razonyang razonyang linked an issue Oct 24, 2021 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Oct 24, 2021

✔️ Deploy Preview for hugo-theme-bootstrap ready!

🔨 Explore the source changes: 9f907da

🔍 Inspect the deploy log: https://app.netlify.com/sites/hugo-theme-bootstrap/deploys/61753ea81d64220007d698da

😎 Browse the preview: https://deploy-preview-240--hugo-theme-bootstrap.netlify.app

@razonyang razonyang changed the title feat: use Vieweinstead of built-in image viewer feat: use Viewer.js instead of built-in image viewer Oct 24, 2021
@simgunz
Copy link

simgunz commented Oct 24, 2021

I've just tried the deploy preview. The plugin seems nice and the fact that it is possible to configure it is great.

Some personal opinions:

  • The bottom toolbar is overwhelming, I would keep a simple toolbar by default and leave the developers the option to add functionalities as needed
    • rotable: false
    • movable: false
    • scalable: false
    • toolbar: "zoomIn", "zoomOut", "prev", "play", "next"
  • The backdrop color is too light for me, I would change the opacity to >=0.85

One note, google page speed seems to be impacted a lot by this plugin, especially on mobile (not sure if it is just the netlify deploy preview that alters the results).

@razonyang
Copy link
Owner Author

  • The bottom toolbar is overwhelming, I would keep a simple toolbar by default and leave the developers the option to add functionalities as needed

    • rotable: false
    • movable: false
    • scalable: false
    • toolbar: "zoomIn", "zoomOut", "prev", "play", "next"

I prefer keeping the default options of the plugin provided, in order to show all abilities it has.

  • The backdrop color is too light for me, I would change the opacity to >=0.85

I agree with you.

One note, google page speed seems to be impacted a lot by this plugin, especially on mobile (not sure if it is just the netlify deploy preview that alters the results).

Don't be worry, it is because a lot of Netlify' assets slow down the page load.

@razonyang razonyang merged commit f04c81b into master Oct 24, 2021
@razonyang razonyang deleted the feature-image-viewer branch October 24, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Gallery
2 participants