Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add gallery shortcode to create a Masonry with the Bootstrap grid system and cards component #481

Closed
wants to merge 4 commits into from

Conversation

costalfy
Copy link
Contributor

Hi,
I just add a new shortcode to create a gallery of images and use Masonry with the Bootstrap grid system and cards component as explained on https://getbootstrap.com/docs/5.1/examples/masonry/
I also add a tiny documentation page to use it

Thanks for this amazing theme

Regards

@netlify
Copy link

netlify bot commented Mar 25, 2022

Deploy Preview for hugo-theme-bootstrap ready!

Name Link
🔨 Latest commit 7aed7c5
🔍 Latest deploy log https://app.netlify.com/sites/hugo-theme-bootstrap/deploys/623e0c7c91892a000843255e
😎 Deploy Preview https://deploy-preview-481--hugo-theme-bootstrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@costalfy costalfy changed the title Add gallery shortcode to create a Masonry with the Bootstrap grid system and cards component feat: Add gallery shortcode to create a Masonry with the Bootstrap grid system and cards component Mar 25, 2022
@razonyang
Copy link
Owner

Thanks for your contributions!

It seems that Masonry JS hasn't been imported yet. I'll clone your fork and play around with it, in order to make sure it works.

@razonyang razonyang added the enhancement New feature or request label Mar 26, 2022
@costalfy
Copy link
Contributor Author

Thanks 😊.
I don't think JS is needed because it's already working on the sample page https://deploy-preview-481--hugo-theme-bootstrap.netlify.app/en/docs/shortcodes/gallery/

@razonyang
Copy link
Owner

Thanks 😊. I don't think JS is needed because it's already working on the sample page https://deploy-preview-481--hugo-theme-bootstrap.netlify.app/en/docs/shortcodes/gallery/

It only works on images with same ratio, I'll handle the rest.

@razonyang
Copy link
Owner

razonyang commented Mar 26, 2022

I created another PR #483, since I didn't have access to push commit to your fork. The commits are still credited by you.
Close this.

I change the usage as well. https://hbs.razonyang.com/en/docs/shortcodes/gallery/.

@razonyang razonyang closed this Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants