Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace fixed position with sticky for header #921

Merged
merged 1 commit into from
Apr 6, 2023
Merged

fix: replace fixed position with sticky for header #921

merged 1 commit into from
Apr 6, 2023

Conversation

razonyang
Copy link
Owner

There are some issues and limitations of the fixed header.

  1. Hard to append custom code to the beginning of <body>.
  2. The main-begin hook sucks.

@razonyang razonyang added the bug Something isn't working label Apr 6, 2023
@netlify
Copy link

netlify bot commented Apr 6, 2023 •
edited
Loading

✅ Deploy Preview for hbs-docs ready!

Name Link
🔨 Latest commit 0862d3f
🔍 Latest deploy log https://app.netlify.com/sites/hbs-docs/deploys/642ec452180ad40008975d23
😎 Deploy Preview https://deploy-preview-921--hbs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@razonyang razonyang merged commit 323687f into master Apr 6, 2023
@razonyang razonyang deleted the patch-fixed-sticky branch April 6, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@razonyang