Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stale): Stale implementation for issues and pr #334

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ankitdas13
Copy link
Contributor

@ankitdas13 ankitdas13 commented Sep 20, 2022

Stale

Whenever an issue or Pull Request has not been updated for a while, a stale label will be placed to mark it as stale. A closing comment may also be posted to notify contributors.

The stale label is removed if the Issue or Pull Request is updated, or if anyone comments on it.

Use the official Stale action located at https://github.com/actions/stale

Copy link

@sidag95 sidag95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any most options that we can explore?


on:
schedule:
- cron: '29 1 * * *'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: ‏Let's add comments on what this cron time mean

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidag95 added

stale-issue-label: 'Stale'
stale-pr-label: 'Stale'
days-before-stale: 30
days-before-close: 5
Copy link

@kkyusufk kkyusufk Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this to 7. I think we should give folks a week before closing the issues.

@kkyusufk
Copy link

Can you add some description for what is stale bot and where is it's documentation

@ankitdas13
Copy link
Contributor Author

Are there any most options that we can explore?
@kkyusufk
yes we can also use these options
exempt-issue-labels
exempt-pr-labels exempt-pr-labels
close-issue-reason

@ankitdas13
Copy link
Contributor Author

Can you add some description for what is stale bot and where is it's documentation

in stale.yml file ?

@kkyusufk
Copy link

Can you add some description for what is stale bot and where is it's documentation

in stale.yml file ?

In the PR description.

@ankitdas13
Copy link
Contributor Author

Can you add some description for what is stale bot and where is it's documentation

in stale.yml file ?

In the PR description.

i have updated the description is it looks good for you ?

Copy link

@sidag95 sidag95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


on:
schedule:
- cron: '29 1 * * *' # Runs at 01:29 UTC every day.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question(non-blocking): Why such a specific time of the day? 😆‏

@kkyusufk kkyusufk changed the title Stale implementation for issues and pr feat(stale): Stale implementation for issues and pr Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants