Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow fix #94

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Arrow fix #94

wants to merge 4 commits into from

Conversation

HalukaMB
Copy link
Contributor

@HalukaMB HalukaMB commented Dec 7, 2021

Can you please give me feedback whether you are happy with the result and also, how you would refactor the ArrowHead.tsx to make the functions more clear.

@sophiamersmann
Copy link
Member

Thank you! This works well but couldn't this be much simpler? To find a mid point on a line defined by two points, wouldn't you only need the distance between those points and then you can work with the ratio? I haven't tried, so I might be mistaken

@sophiamersmann
Copy link
Member

I think this line breaks the build:

import { args } from 'react';

args is likely a leftover from Storybook, it can be safely removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants