-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ruby-build ruby-X.Y.Z DIR
#2448
Support ruby-build ruby-X.Y.Z DIR
#2448
Conversation
* By searching a X.Y.Z definition if no ruby-X.Y.Z definition is not found.
30d5393
to
49dd050
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some feature in this direction would be great; thank you.
But first of all: without #2447 I don't think this feature makes sense on its own, so I would even suggest lumping it together in a single PR rather that treating them as distinct features. WDYT?
Second, if ruby-build 3.3.4 ...
and ruby-build ruby-3.3.4 ...
are basically equivalent invocations since they resolve to the same version of CRuby, should they be guaranteed to be completely interchangeable? I'm asking because it seems that if you add the -d
option to this invocation, you will end up with different installation prefixes based on your argument input. That seems slightly wrong to me because I think it could be seen as counter-intuitive.
It's how I had it locally but I figured it's easier to review independently, and this change has value on its own (first example and last paragraph of the description).
Indeed it will install to either $PREFIX/3.3.4 or $PREFIX/ruby-3.3.4.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Added some tests and documentation updates. Feel free to merge when all looks good to you 🙏
Amazing, thank you! |
So this enables for example:
And with #2447 it enables:
It would remove the need for https://github.com/ruby/ruby-builder/blob/135bc7c215df24a672d0735189aafc510923d380/.github/workflows/build.yml#L67-L74 and likely other places working around the "asymmetry" that CRuby definitions don't have a prefix.