Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid array subscript error when checking OpenSSL versions #2461

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mislav
Copy link
Member

@mislav mislav commented Nov 5, 2024

If none of Homebrew OpenSSL versions satisfy the needs_openssl requirement, array iteration will reach index=-1 and that will raise a non-fatal error when accessing the versions array. This makes sure not to go past index=0.

Fixes #2455

If none of Homebrew OpenSSL versions satisfy the `needs_openssl` requirement,
array iteration will reach `index=-1` and that will raise a non-fatal error
when accessing the `versions` array. This makes sure not to go past index=0.
@mislav mislav merged commit 1ab17da into master Nov 5, 2024
6 checks passed
@mislav mislav deleted the openssl-version-check branch November 5, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"bad array subscript" error
2 participants