feat(netcore): start covering conn.go code #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff starts adding tests to increase the coverage of code in the netcore package and specifically in conn.go. We want to have reasonably good coverage of functionality and error paths for the netcore package ahead of migrating this code, which now seems to be stable, to its own package. While there, upgrade dependencies to silence an otherwise harmless security advisory (we do not use `x/net/html` here).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff starts adding tests to increase the coverage of code in the netcore package and specifically in conn.go.
We want to have reasonably good coverage of functionality and error paths for the netcore package ahead of migrating this code, which now seems to be stable, to its own package.
While there, upgrade dependencies to silence an otherwise harmless security advisory (we do not use
x/net/htmlhere).