Add FreeBSD support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library supports Linux, OSX and Windows, but not FreeBSD yet. This change * Adds FreeBSD support via `ptrace (2)` `PT_VM_ENTRY` call. * Bumps `libc` crate version in order to get broader `ptrace (2)` call types support, namely `PT_VM_ENTRY`. * Adds Cirrus-backed FreeBSD CI. `libc` crate uses Cirrus for the very same purpose. * Adds mentions of FreeBSD in docstrings where appropriate.
|
In order to set Cirrus CI up, please follow the guide: https://cirrus-ci.org/guide/quick-start/ I'd be happy to assist. |
benfred
reviewed
Jul 13, 2019
This change contains post-code review fixes, namely: * implement `Drop` trait for `VmEntryIterator` in order to avoid possible error when the iterator is not exhausted and the tracee process remain attached. * Move process locking logic to `VmEntryIterator::new`.
benfred
approved these changes
Jul 14, 2019
|
Thanks for this! I've pushed a new version that includes these changes (0.1.6). Will get CI set up in a bit, |
|
Alright, I have updated the py-spy PR accordingly, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library supports Linux, OSX and Windows, but not FreeBSD yet.
This change
ptrace (2)PT_VM_ENTRYcall.libccrate version in order to get broaderptrace (2)calltypes support, namely
PT_VM_ENTRY.libccrate uses Cirrus for the verysame purpose.