Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workrave dependencies on Windows? #367

Closed
teknowledgist opened this issue Dec 9, 2021 · 12 comments
Closed

Workrave dependencies on Windows? #367

teknowledgist opened this issue Dec 9, 2021 · 12 comments

Comments

@teknowledgist
Copy link

I'm trying to get an automated install of Workrave onto a bare-bones, really-old remote system, and it seems to fail with an error 5. It works great on all the more modern, patched, etc. systems I test it on (to which I also have direct access).

Since Workrave appears to be compatible all the way back to WinXP, I'm guessing there is some kind of library dependency that this remote system is missing. The installer might even be reporting that, but I can't see it.

I'm fine with installing additional libraries as needed, but I also need to know what those are. Thanks!

@teknowledgist
Copy link
Author

Logging into a bare-bones 2012r2 system and attempting to install WorkRave manually gives me this near the end of the install:

InstallFail

The binaries appear to all be in the C:\Program Files (x86) and the Start Menu shortcut is there, but it all gets reverted if you cancel. If you "ignore" the error, WorkRave does launch and appears to work at first glance. The problem is, I need to be able to install this silently and without user interaction.

Since this works fine on newer Windows systems and I don't find reports of it failing on other older versions of Windows, I have to assume that it is a dependency issue. Please let me know what dependency it has so I can install that first.

@rcaelers
Copy link
Owner

I am not aware of any additional libraries needed. I don't have access to an XP system, unfortunately. So I can't test this.

The error is caused by not having administrator rights that are required to register the applet. You can safely ignore the error and continue installation. Workrave will be functional, except the taskbar applet.

You can add some options to the installer to make it silent: https://jrsoftware.org/ishelp/index.php?topic=setupcmdline.

@teknowledgist
Copy link
Author

teknowledgist commented Dec 30, 2021

It can't be an administrator rights issue because I get that error running the installer as admin.

I have some experience with silent installs and know about the options. 😄

The problem is the verification system in place for Chocolatey is completely automatic. There is no "ignore the error and continue" option. The silent install either works or doesn't, and it is tested on a (IMHO, ridiculously) outdated system. You might notice that previous releases did work. It's only this latest one that is giving the error.

I'll see if I can poke "deeper" to better identify the source of the issue, but if you have any inspirations, I'm happy to test beta installers.

@teknowledgist
Copy link
Author

Just for reference, v1.10.44 installs just fine on the older 2012r2 system. Version 1.10.45 has the same error on that older system that v1.10.48 and v1.10.49 have above.

I don't know if it helps because nobody wants to look at code from almost a year ago, but whatever is causing the error was introduced in v1.10.45.

@rcaelers
Copy link
Owner

I found a 2012r2 download on Microsoft's website and managed to reproduce this. In 1.10.45 I switched to Visual Studio 2019 for compiling the applet. The previous versions were compiled with Visual Studio 2015. I am trying to change the build to support Windows 8.1 and up (WINVER >= 0x603), but it seems the applet now uses a function (GetDpiForWindow) that requires Windows 10. I will change the applet to check at runtime if this function is available.

@rcaelers
Copy link
Owner

The latest 1.10 build from https://workrave.org/snapshots/ should install correctly on Windows 2012r2. The fix will also be in Workrave 1.10.50.

Please re-open this issue oiff my fix doesn't solve the issue for you.

@teknowledgist
Copy link
Author

I'm getting the same error with the 1.10.49+445commits download.

@teknowledgist
Copy link
Author

I don't know how to re-open the issue (or don't have rights).

@rcaelers rcaelers reopened this Jan 29, 2022
@rcaelers
Copy link
Owner

1.10.49+445 commits is the upcoming 1.11 release. It will soon be tagged as 1.11-alpha1. This version will for sure not work on 2012r2. Please try the 1.10 release (1.10.49 + 13)

@DeronLJ
Copy link

DeronLJ commented Jan 30, 2022

I can confirm that the warning no longer shows up when installing v1_10_49-13 on Windows 7. Thank you!

@rcaelers
Copy link
Owner

Thanks for the feedback!

@teknowledgist
Copy link
Author

Ah! Sorry, I misunderstood what to download for testing. I have also now confirmed that the 1.10.49-13commits installer works flawlessly on the older system. Since it is a pre-release, I'm going to hold off on submitting an updated package to the Chocolatey public repository, but I will as soon as 1.10.50 is officially available.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants