Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workrave is not compatible with GNOME Shell 46 #532

Closed
jbicha opened this issue Feb 26, 2024 · 6 comments
Closed

Workrave is not compatible with GNOME Shell 46 #532

jbicha opened this issue Feb 26, 2024 · 6 comments

Comments

@jbicha
Copy link
Contributor

jbicha commented Feb 26, 2024

Describe the bug
I built workrave with --enable-gnome45 and tweaked metadata.json to include "46". When I tried enabling the extension on GNOME Shell 46 Beta, I got this error in Extension Manager

Extension workrave@workrave.org: TypeError: this._box.add_actor is not a function

Stack trace:
  _init@file:///usr/share/gnome-shell/extensions/workrave@workrave.org/extension.js:185:17
  ButtonBox@resource:///org/gnome/shell/ui/panelMenu.js:13:1
  PanelMenuButton@resource:///org/gnome/shell/ui/panelMenu.js:99:4
  WorkraveButton@file:///usr/share/gnome-shell/extensions/workrave@workrave.org/extension.js:162:3
  enable@file:///usr/share/gnome-shell/extensions/workrave@workrave.org/extension.js:518:27
  _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:264:38
  async*_onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:626:24
  _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:731:18
  createCheckedMethod/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:730:46
  enableExtension@resource:///org/gnome/shell/ui/extensionSystem.js:287:29
  EnableExtension@resource:///org/gnome/shell/ui/shellDBus.js:453:38
  _handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:329:38
  _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34
  @resource:///org/gnome/shell/ui/init.js:21:20

Other Info
Here is documentation about some of the changes in GNOME Shell 46

https://gjs.guide/extensions/upgrading/gnome-shell-46.html

rcaelers added a commit that referenced this issue Mar 8, 2024
@rcaelers
Copy link
Owner

Should be fixed in beta11. Not yet in 1.10

rcaelers added a commit that referenced this issue Mar 29, 2024
@rcaelers
Copy link
Owner

Also committed to 1.10 (5a6d524)

@pieterdd
Copy link
Contributor

Thank you for implementing the fix. Any indication as to when it will be released? Ubuntu LTS and Fedora ship with GNOME 46 now, so the fix would be a big help to those users.

@fmarier
Copy link
Contributor

fmarier commented May 11, 2024

Ubuntu LTS and Fedora ship with GNOME 46 now, so the fix would be a big help to those users.

The current Ubuntu LTS already has the required fixes: https://launchpad.net/ubuntu/+source/workrave/1.10.52-2ubuntu1

@pieterdd
Copy link
Contributor

I see a Fedora release as well, and 1.10.52 - 4.fc40 is reported as installed on my machine, but the GNOME extension manager is still reporting the extension as incompatible 🤔

image

@jbicha
Copy link
Contributor Author

jbicha commented May 14, 2024

You need to report that issue to the Fedora maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants