Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with multigrid since last commit #93

Closed
ttytm opened this issue May 3, 2022 · 4 comments
Closed

Incompatible with multigrid since last commit #93

ttytm opened this issue May 3, 2022 · 4 comments

Comments

@ttytm
Copy link

ttytm commented May 3, 2022

Notifications do not show correctly when using environments with multigrid like neovide or nvui since the last commit.

@rcarriga
Copy link
Owner

rcarriga commented May 3, 2022

Please provide more information as I do not use these tools. Detailed description of an error, screenshots, recordings, steps to reproduce etc

@ttytm
Copy link
Author

ttytm commented May 3, 2022

Yes, I understand when someone's not using those toys. Usually it's the also my choice to go as raw as possible. But it really makes a beneficial difference for me in eye strain and development experience. Things like following cursor movement when, for example, switching windows etc. is easier... Just many situations where I don't want to miss something that is smoothly rendered anymore.

To describe the problem: A Notification usually remains invisible since the last commit, independent of what's triggering it. For the example of the following video, notify gets triggered by font scaling. I'm using a small lua plugin I wrote(size-matters maybe this can serve as a tool for debugging idk). The notifications are just briefly visible when scaling down.

nofify-multigrid.mp4

Here is the quick video.You see switching to the current main branch of notify then starting with an app with multigrid enabled. Notifications do not appear when triggered without scaling or scaling up. But when scaling down while triggering a notification, you see that notifications indeed are there, but they seem to live outside the viewport and very briefly. Then starting without multigrid and it's working fine. Then going back to the penultimate commit, and it also works fine with multigrid enabled.
It's hard giving more details as I don't know how to debug this. If you have the time maybe you can do tests or tell me what I can do here to provide you better information.

(I hope I don't confuse anyone with the scaling thing, because this is not a scaling issue. Just when not coincidentally scaling down simultaneously with a Notification event it remains invisible.)

rcarriga added a commit that referenced this issue May 4, 2022
Regression from available_slot change.
See #93
@rcarriga
Copy link
Owner

rcarriga commented May 4, 2022

That's perfect thank you, this should be fixed in the latest commit. The cause was using the wrong anchor for the floating value, which didn't appear in regular terminal neovim because it limits the bounds to the screen whereas it seems Neovide allows for moving windows off screen

@ttytm
Copy link
Author

ttytm commented May 4, 2022

Perfect, thanks alot!

@rcarriga rcarriga closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants