Merge duplicate notifications #278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it happens that the same notification is displayed multiple times, usually due to some buggy callback. In such scenario, instead of displaying multiple duplicate notifications, they just replace the initial one. Renderers can use
#notif.duplicatesto display duplicates count.Specifying
merge_duplicatesas integer works as minimal duplicates count, but the way it is implemented right now may give somewhat unexpected result - it will replace only one of the previous notifications, but renderer will display total different duplicate counts on all, so overall duplicate count is not the sum of displayed ones. If this is unwanted then we may just remove option to use integer.Example with the default renderer and
merge_duplicates = true:merge_duplicates.mp4