Parse xml responses files as xml files #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samogot Can you add a test? |
rchipka
reviewed
May 12, 2018
| parse_mode = getResponseType(res.headers['content-type']); | ||
| try { | ||
| if (parse_mode === 'xml') | ||
| document = libxml.parseXml(document, {baseUrl: location.href, huge: true}); |
There was a problem hiding this comment.
Hmm, was it always throwing on parse errors or is this new with parseXml?
Can you try adding the XML parse option errors: false so we can avoid the try/catch?
There was a problem hiding this comment.
Libxmljs docs says that unrecoverable errors are "thrown and need to be caught". I don't know is there any fatal errors in html mode, though. But anyway using try-catch even for html is safer, just in case. Why don't you like it?
Xml throws even with errors: false. Looks like this option is only about recoverable errors.
For example it fixes interpretation of opening <link> tag in RSS as HTML inline tag <link /> without text content. Also allow to overwrite parsing method.
Xml parsing is more strict and have more unrecoverable errors like absence of root element or multiply root elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example it fixes interpretation of opening tag in RSS as HTML
inline tag without text content.
Also allow to overwrite parsing method.
Fixes #204