Implements throttling #210
Open
+184
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchipka
reviewed
May 12, 2018
index.js
Outdated
| @@ -321,6 +325,8 @@ Osmosis.prototype.resources = function () { | |||
| 'requests: ' + this.requests + | |||
| ' (' + this.queue.requests + ' queued), ' + | |||
|
|
|||
| 'tokens: ' + parseInt(this.throttle.getTokensRemaining()) + ', ' + | |||
There was a problem hiding this comment.
Can we change tokens: to throttled:
|
looks like something has changed in libxmljs and it no longer supports ES5 environment. Or I can't understand what this error is mean and how it relates too my changes) |
As was documented in command comments. That allows to set global throttle as well as dynamically change throttle command-wise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #104 PR by @JonnyBGod
Tests added