Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add environment support for using brew's ruby installation with brew-gem #68

Merged
merged 1 commit into from
Nov 9, 2016

Conversation

boneskull
Copy link
Contributor


I had some questions here:

  • Not entirely sure about the formatting used in brew-file, but I did my best.
  • Only --homebrew-ruby is supported by HOMEBREW_GEM_OPTS, but I could change this to allow anything. As-is, it's pretty defensive to have it be explicit, and adds edge-case conditionals around the code.
  • A better solution may be generic option support via an env var for both this and brew-pip...

- the `--homebrew-ruby` flag to `brew-gem` will tell it to use the Ruby as installed by Homebrew (see sportngin/brew-gem#29)
- allow `HOMEBREW_GEM_OPTS` environment variable so users don't need to type `--homebrew-ruby` every time
- updated docs
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 82.985% when pulling 85de314 on boneskull:brew-gem-homebrew into 4889745 on rcmdnk:master.

@rcmdnk rcmdnk merged commit ed3f511 into rcmdnk:master Nov 9, 2016
@rcmdnk
Copy link
Owner

rcmdnk commented Nov 9, 2016

Thanks for the PR.
It's fine with me and merged.

maybe it is also useful if cask_opt also can be passed from args directly.
I will think about it later (or any PR is welcome:smile:).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants