Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs for linux-syscall and fix "uname" command #125

Merged
merged 8 commits into from
Aug 6, 2020

Conversation

yunwei37
Copy link
Contributor

@yunwei37 yunwei37 commented Aug 3, 2020

linux-syscall passes #![deny(missing_docs)].

reference:

  • system reference manuals section 2: System calls

fix #26 : The "uname" command shows up incorrect results

@coveralls
Copy link

coveralls commented Aug 3, 2020

Pull Request Test Coverage Report for Build 197145099

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 32 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.02%) to 29.726%

Changes Missing Coverage Covered Lines Changed/Added Lines %
linux-syscall/src/task.rs 0 1 0.0%
linux-syscall/src/misc.rs 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
linux-syscall/src/file/stat.rs 1 0%
linux-syscall/src/time.rs 1 0%
linux-syscall/src/task.rs 2 9.56%
linux-syscall/src/file/dir.rs 4 0%
linux-syscall/src/lib.rs 5 28.68%
linux-syscall/src/misc.rs 5 14.29%
../../../../../usr/share/rust/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/bitflags-1.2.1/src/lib.rs 6 36.27%
linux-syscall/src/file/file.rs 8 13.45%
Totals Coverage Status
Change from base Build 193518124: 0.02%
Covered Lines: 3714
Relevant Lines: 12494

💛 - Coveralls

@yunwei37 yunwei37 changed the title fix "uname" command Improve docs for linux-syscall and fix "uname" command Aug 5, 2020
@yunwei37 yunwei37 marked this pull request as draft August 5, 2020 01:00
@yunwei37 yunwei37 marked this pull request as ready for review August 5, 2020 05:41
@wangrunji0408 wangrunji0408 added the documentation Improvements or additions to documentation label Aug 6, 2020
Comment on lines +162 to +163
/// If the name was the last link to a file but any processes still have the file open,
/// the file will remain in existence until the last file descriptor referring to it is closed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this feature is not correctly implemented.

linux-syscall/src/lib.rs Outdated Show resolved Hide resolved
@wangrunji0408 wangrunji0408 merged commit 40ecaf0 into rcore-os:master Aug 6, 2020
zhangsn-19 pushed a commit to zhangsn-19/zCore that referenced this pull request Apr 23, 2022
Improve docs for `linux-syscall` and fix "uname" command
@coveralls
Copy link

coveralls commented Jul 14, 2024

Pull Request Test Coverage Report for Build 195623298

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 29 (17.24%) changed or added relevant lines in 5 files are covered.
  • 162 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.08%) to 29.781%

Changes Missing Coverage Covered Lines Changed/Added Lines %
linux-syscall/src/vm.rs 4 5 80.0%
linux-syscall/src/time.rs 0 3 0.0%
linux-syscall/src/misc.rs 1 7 14.29%
linux-syscall/src/lib.rs 0 7 0.0%
linux-syscall/src/task.rs 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
linux-syscall/src/file/stat.rs 1 0.0%
../../../../../usr/share/rust/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/bitflags-1.2.1/src/lib.rs 3 36.27%
linux-syscall/src/file/dir.rs 4 0.0%
linux-syscall/src/time.rs 4 0.0%
linux-syscall/src/file/file.rs 8 13.45%
linux-syscall/src/vm.rs 14 67.31%
linux-syscall/src/misc.rs 16 14.58%
linux-syscall/src/lib.rs 54 29.55%
linux-syscall/src/task.rs 58 9.42%
Totals Coverage Status
Change from base Build 193518124: 0.08%
Covered Lines: 3720
Relevant Lines: 12491

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "uname" command shows up incorrect results
3 participants