-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for different logo variants #119
Conversation
cdfcead
to
389000d
Compare
Bumping this decision to @mbarton : possibly need a copyright/TM logo here next to RCPCH. Not also sure if having the logo present in the 'powered by' statement. |
I don't know what decision making process in the college would decide where the logo should be and if it's required. So to avoid any unnecessary delays in your testing I would suggest we go with "Powered by RCPCH Digital Growth Charts - Version XXX" and no logo. |
Hi @mbarton @eatyourpeas I updated the text according to your feedback. Thanks. |
Hi @mbarton what do you think about using From I can do the change if you agree. |
Hi @gdfreitas I hope you don't mind me pushing to this PR. I think this is great and thank you for you time and thought putting it together. The extra bits I have added:
|
Feature
Introduces a
logoVariant
property that accepts:top (default)
bottom
legend
.In our use case would like use
legend
.What do you guys think?