Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain errors saving patient or visit after CSV upload #347

Closed
mbarton opened this issue Oct 31, 2024 · 2 comments
Closed

Retain errors saving patient or visit after CSV upload #347

mbarton opened this issue Oct 31, 2024 · 2 comments

Comments

@mbarton
Copy link
Member

mbarton commented Oct 31, 2024

  1. Remove NHS number from a row in dummy_sheet.csv
  2. Upload the CSV file

At the moment, you see an error flashed up in messages but once you reload the page you have no idea the upload failed.

I think we should retain such errors as an errors field on the submission itself. We can then show a summary of all errors on the front page of the submission, combining those errors saving the CSV row at all with validation errors on the Patients and Visits from rows we have managed to save

@mbarton
Copy link
Member Author

mbarton commented Oct 31, 2024

This would potentially give us space to implement #334 too

@eatyourpeas
Copy link
Member

I think both of these items are now implemented - there is a toast message that appears if there are typing errors that fail import into the dataframe and the CSV is rejected
For all other errors, there is toast message on redirect to the submission page to say submission made but there are errors to fix, and these are gathered up and posted in a table in the submission page. There is a separate issue to put these as a separate sheet in the excel or csv.

This feature does not handle the no NHS number issue - I am not clear if we should reject these CSVs outright, or retain them. My feeling is probably we should reject the whole csv and signpost which numbers are missing.

@reecehill reecehill removed their assignment Nov 11, 2024
@mbarton mbarton closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants