Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV upload tests should call the route directly #353

Open
mbarton opened this issue Nov 7, 2024 · 0 comments
Open

CSV upload tests should call the route directly #353

mbarton opened this issue Nov 7, 2024 · 0 comments

Comments

@mbarton
Copy link
Member

mbarton commented Nov 7, 2024

At the moment test_csv_upload is a mixture of calling read_csv and upload_csv. It would be better to make them true e2e tests and call the route directly so that we catch any problems in the code that shows the error messages to the user.

Probably can't do this before #347 as that would provide the mechanism to read back the errors in the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant