use contextmanager to open/close files #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps cleaning up files access and ensures that they are closed again. This will stop the leaks happening.
kain88-de
force-pushed
the
open-files
branch
from
bbe2115 to
25a3754
Compare
|
thanks! nice |
|
Hi do you mind making a release? I'm tracking warnings in MDAnalysis testsuite and mmtf currently has a lot of resource warnings because of the open file leaks. Also happy new year! |
|
Should be released now - 1.0.10. Thanks for the fix! Let me know if any
problems.
Best wishes,
Anthony
…On Tue, Jan 2, 2018 at 8:47 PM Max Linke ***@***.***> wrote:
Hi do you mind making a release? I'm tracking warnings in MDAnalysis
testsuite and mmtf currently has a lot of resource warnings because of the
open file leaks.
Also happy new year!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#32 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFuRIVBG6RsQVFC4IN37rQNAXr8fXl6uks5tGofsgaJpZM4REfEw>
.
|
|
Thanks. I also updated the conda-forge package. |
|
I wasn't even aware you'd made one! That's awesome. I love open-source
projects when that happens!
…On Wed, Jan 3, 2018 at 11:36 AM Max Linke ***@***.***> wrote:
Thanks. I also updated the conda-forge package.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#32 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFuRIb_PnQK25ORPm4rvfF0scDXikq1uks5tG1hHgaJpZM4REfEw>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps cleaning up files access and ensures that they are closed
again. This will stop the leaks happening.