Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot notation, readthedocs, query validation #31

Merged
merged 120 commits into from
Aug 28, 2024
Merged

Dot notation, readthedocs, query validation #31

merged 120 commits into from
Aug 28, 2024

Conversation

ivana-truong
Copy link
Collaborator

@ivana-truong ivana-truong commented Aug 19, 2024

  • Added query validation through graphql-core package
  • Query must be executed using '.exec()'
  • Package is initialized with __init__.py
  • Dot notation is supported
    • allows you to specify a full query path
    • throws error if there are other paths of equal length and includes warning that list may not be complete
  • readthedocs created and Google Colab links for notebooks added
  • If fails to fetch schema online, fall back on local file.
  • query_construction changed to use simple_paths not shortest_paths
    • in the case of loops or paths not on the simple_paths list, separately resolve the dot path into indices. Then find the shortest path from the input_type index to the beginning of given dot path and make into a full path.
    • simulated weighing of assembly edges by removing paths that are equivalent to other paths, but go through "assemblies"
  • change find_field_names to return only matching field names (no description)
    • delete field_description_dict
  • update tests and examples to work with changes
  • update documentation to match changes
  • more typing and docstrings

ivana-truong and others added 30 commits July 26, 2024 17:36
Copy link
Collaborator

@piehld piehld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ivana-truong ivana-truong merged commit 74d6de2 into master Aug 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants