Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Do not merge until validation recalculation) Use mmCIF validation reports instead of XML #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

aliciaaevans
Copy link
Contributor

@aliciaaevans aliciaaevans commented Jun 27, 2023

Once validation recalculation is done, every entry will have an mmCIF validation report. ThetoCifWrapper marshal helper and internal validation dictionary will no longer be needed. Instead, the CIF can be merged with the structure's mmCIF.

@aliciaaevans aliciaaevans changed the title (Do not merge until validation remediation) Use mmCIF validation reports instead of XML (Do not merge until validation recalculation) Use mmCIF validation reports instead of XML Jun 27, 2023
@aliciaaevans
Copy link
Contributor Author

aliciaaevans commented Jun 27, 2023

Note: the testLocalRepoUtils tests won't pass until after the recalculation because it's expecting a certain number of categories, including vrpt, to be found. Also, the validation cif files need to be added to the mock-data repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants