Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is IEEE compliance for CW floating point add/mul set to 0? #972

Open
jack-melchert opened this issue Oct 26, 2020 · 2 comments
Open

Comments

@jack-melchert
Copy link
Collaborator

{"ieee_compliance", Const::make(c, false)}});

{"ieee_compliance", Const::make(c, false)}});

This causes errors when simulating lassen with CW floats:
StanfordAHA/lassen#178

Setting ieee_compliance to true fixes this issue. Is there any reason why it was set to false in the first place?

@rdaly525
Copy link
Owner

ieee_compliance is essentially a switch indicating compliance with subnormal/denormal floating point values. If you are seeing testing errors, that might mean that we are generating subnormal numbers in the tests. If I recall correctly, we were not trying to support these. Ill try to dig up an email discussing this issue.

@rdaly525
Copy link
Owner

That being said, CoreIR should probably expose that flag as a parameter to be decided by the user of the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants