Encode URI templates according to spec #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpluscode
commented
Dec 18, 2021
| @@ -1,4 +1,5 @@ | |||
| const fs = require('fs') | |||
| const encodeURIComponent = require('strict-uri-encode') | |||
There was a problem hiding this comment.
This is not exactly related to the issue but I thought it useful to actually produce correct templates. While I did not observe any problems, according to the URI Templates spec, template variables should also be encoded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that templates were incorrectly produced, cells being not fully encoded as per RFC3986.
For example, parentheses were not percent-encoded, likely being done by JS' flawed implementation of
encodeURIComponentThis PR switches to a different implementation of the RFC6570 spec which does the encoding correctly.