Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LNG_LIVE_RELOAD_HOST environment variable #203

Merged
merged 3 commits into from
Sep 21, 2022
Merged

add LNG_LIVE_RELOAD_HOST environment variable #203

merged 3 commits into from
Sep 21, 2022

Conversation

cidevant
Copy link
Contributor

This PR allows you to configure livereload websocket host.
Now livereload host is hardcoded to 'localhost' and can't be used in custom dev setups.

@michielvandergeest
Copy link
Contributor

@cidevant thanks for this PR. This looks like a useful addition! Could you please add this new option to the documentation as well?

@sandeep-vedam the code change looks like little impact, but could you perform a quick sanity test for this feature, just to be sure?

@cidevant
Copy link
Contributor Author

@michielvandergeest docs are updated

@sandeep-vedam
Copy link
Contributor

@cidevant Thanks for updating the documentation.

@michielvandergeest Sure will verify

@sandeep-vedam sandeep-vedam self-requested a review September 21, 2022 10:26
Copy link
Contributor

@sandeep-vedam sandeep-vedam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and this feature is working fine

@sandeep-vedam sandeep-vedam changed the base branch from master to dev September 21, 2022 10:50
@sandeep-vedam sandeep-vedam merged commit c865647 into rdkcentral:dev Sep 21, 2022
cidevant pushed a commit to cidevant/Lightning-CLI that referenced this pull request Oct 25, 2022
add LNG_LIVE_RELOAD_HOST environment variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants