Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Storybook): fixes white flashes between loading #414

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

arwehrman
Copy link
Contributor

Description

Prior to 6.5, we were able to set appBG in the custom Storybook Theme to set the background in the Preview iframe. This is no longer the case. There are possible fixes coming but have not seen them actually committed to a release yet. storybookjs/storybook#24575

The other known issue is a white flash when clicking from a Story to the Docs of that Story. This is related to some classes being displayed and not displayed during 'loading' of the pages. The CSS overrides added in this PR are to fix those issues until Storybook fixes them. See this issue

This PR makes a few updates to the Storybook styles configuration:

  • Adds CCS style overrides for style overrides the known appBG and the loading issue styles when clicking between Stories and Docs

References

LUI-1200

Testing

  • clone pr
  • go to multiple Components
  • click from the Story to the Docs and back. You should no longer see the white flash

Automation

Checklist

  • all commented code has been removed
  • any new console issues have been resolved
  • code linter and formatter has been run
  • test coverage meets repo requirements
  • PR name matches the expected semantic-commit syntax

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@ImCoolNowRight ImCoolNowRight force-pushed the fix/storybook-white-flash-loading branch from 3e68958 to 0ed958e Compare November 21, 2023 22:46
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Passed.

@ImCoolNowRight ImCoolNowRight merged commit 9305c9a into develop Nov 21, 2023
@ImCoolNowRight ImCoolNowRight deleted the fix/storybook-white-flash-loading branch November 21, 2023 23:01
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Passed.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants