-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to send response in the fireboltInteraction logs #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIRECERT-2189 Changes to send response in the fireboltInteraction logs
Eswar2103
changed the title
FIRECERT-2189 Changes to send response in the fireboltInteraction logs
Changes to send response in the fireboltInteraction logs
Jul 11, 2024
kevinshahfws
approved these changes
Jul 12, 2024
brendanobra
reviewed
Jul 15, 2024
@@ -263,7 +263,7 @@ impl ExtnRequestProcessor for OpMetricsProcessor { | |||
.operational_telemetry_listener(&requestor, true), | |||
OperationalMetricRequest::UnSubscribe => state | |||
.metrics | |||
.operational_telemetry_listener(&requestor, true), | |||
.operational_telemetry_listener(&requestor, false), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugfix, bonus!
satlead
approved these changes
Jul 15, 2024
Minimum allowed line rate is |
B-Larsen
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIRECERT-2189 Changes to send response in the fireboltInteraction logs
What
What does this PR add or remove?
Added response field in fireboltInteraction.
Why
Why are these changes needed?
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist