Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to send response in the fireboltInteraction logs #560

Merged
merged 7 commits into from
Jul 17, 2024

Conversation

Eswar2103
Copy link
Collaborator

FIRECERT-2189 Changes to send response in the fireboltInteraction logs

What

What does this PR add or remove?
Added response field in fireboltInteraction.

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

FIRECERT-2189 Changes to send response in the fireboltInteraction logs
@Eswar2103 Eswar2103 changed the title FIRECERT-2189 Changes to send response in the fireboltInteraction logs Changes to send response in the fireboltInteraction logs Jul 11, 2024
@@ -263,7 +263,7 @@ impl ExtnRequestProcessor for OpMetricsProcessor {
.operational_telemetry_listener(&requestor, true),
OperationalMetricRequest::UnSubscribe => state
.metrics
.operational_telemetry_listener(&requestor, true),
.operational_telemetry_listener(&requestor, false),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix, bonus!

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Code Coverage

Package Line Rate Health
device.thunder_ripple_sdk.src.client 74%
device.thunder_ripple_sdk.src.events 4%
core.sdk.src.api 78%
core.main.src.broker 35%
core.sdk.src.utils 53%
device.mock_device.src 52%
distributor.general.src 2%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src.state 22%
core.sdk.src.extn.ffi 80%
core.main.src.utils 29%
core.launcher.src.manager 7%
core.sdk.src.api.observability 68%
device.thunder_ripple_sdk.src.processors 10%
core.main.src.service 31%
device.thunder_ripple_sdk.src.bootstrap 0%
core.main.src 0%
core.main.src.processor.storage 0%
core.sdk.src.extn.client 91%
core.main.src.processor 0%
core.main.src.bootstrap.extn 0%
core.main.src.service.apps 47%
core.main.src.firebolt.handlers 1%
core.launcher.src 0%
core.main.src.bootstrap.manifest 0%
core.main.src.bootstrap 0%
core.main.src.service.extn 40%
core.main.src.state.cap 44%
core.sdk.src.api.distributor 84%
core.sdk.src.api.firebolt 78%
core.sdk.src.api.gateway 87%
core.main.src.broker.thunder 55%
core.tdk.src.gateway 100%
core.tdk.src.utils 0%
device.thunder.src 0%
core.sdk.src.framework 75%
device.thunder_ripple_sdk.src 15%
core.main.src.firebolt 1%
core.sdk.src.api.manifest 91%
device.thunder.src.bootstrap 0%
openrpc_validator.src 90%
core.sdk.src.api.device 77%
core.sdk.src.extn 83%
Summary 43% (17185 / 40041)

Minimum allowed line rate is 41%

@kevinshahfws kevinshahfws merged commit 4cfa114 into main Jul 17, 2024
8 checks passed
@kevinshahfws kevinshahfws deleted the FIRECERT-2189 branch July 17, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants