Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPPL-2360:Update LOG level for ripple.service #561

Merged
merged 2 commits into from
Jul 11, 2024
Merged

RPPL-2360:Update LOG level for ripple.service #561

merged 2 commits into from
Jul 11, 2024

Conversation

pkumbh631
Copy link
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@@ -4,8 +4,8 @@ After=wpeframework.service

[Service]
Type=notify
Environment="RUST_LOG=debug"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, this should still be here as a fallback of last resort, as Environment="RUST_LOG=info"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would System Services set the Environment values before ExecStartPre

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it , I was wondering if we needed to keep this as a fallback in case something happens in ExecStartPre.

Copy link

Code Coverage

Package Line Rate Health
core.main.src.processor.storage 0%
device.mock_device.src 52%
openrpc_validator.src 90%
core.sdk.src.api.distributor 84%
core.launcher.src.manager 7%
device.thunder_ripple_sdk.src.processors 10%
core.main.src.processor 0%
core.main.src.bootstrap.manifest 0%
core.main.src.state.cap 44%
core.main.src.bootstrap 0%
core.sdk.src.api 78%
core.sdk.src.extn.client 91%
device.thunder_ripple_sdk.src.bootstrap 0%
core.main.src 0%
core.sdk.src.extn 83%
distributor.general.src 2%
core.main.src.firebolt.handlers 1%
core.sdk.src.utils 53%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src.broker 23%
core.main.src.firebolt 1%
core.tdk.src.utils 0%
core.main.src.bootstrap.extn 0%
core.main.src.service 31%
core.main.src.state 21%
core.sdk.src.api.manifest 91%
device.thunder_ripple_sdk.src.client 74%
core.sdk.src.api.gateway 86%
core.sdk.src.framework 75%
device.thunder.src 0%
core.launcher.src 0%
core.main.src.service.apps 47%
core.sdk.src.api.device 77%
core.sdk.src.api.firebolt 78%
core.main.src.service.extn 41%
device.thunder.src.bootstrap 0%
device.thunder_ripple_sdk.src.events 4%
core.sdk.src.api.observability 68%
core.tdk.src.gateway 100%
device.thunder_ripple_sdk.src 15%
core.main.src.utils 10%
core.sdk.src.extn.ffi 80%
Summary 42% (16536 / 38983)

Minimum allowed line rate is 41%

@pkumbh631 pkumbh631 merged commit 4be9633 into main Jul 11, 2024
8 checks passed
@pkumbh631 pkumbh631 deleted the RPPL-2360 branch July 11, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants