Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for x-provided-by Pull pattern #567

Merged
merged 29 commits into from
Jul 26, 2024
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
7171a60
x-provided-by Pull pattern: WIP
pahearn73 Jul 11, 2024
a56383a
x-provided-by Pull pattern: WIP
pahearn73 Jul 11, 2024
ec45fd8
x-provided-by Pull pattern: WIP
pahearn73 Jul 13, 2024
4704007
x-provided-by Pull pattern: Sync'd with base
pahearn73 Jul 13, 2024
0fea010
x-provided-by Pull pattern: Cleaned-up warnings
pahearn73 Jul 13, 2024
9654bce
x-provided-by Pull pattern: Refactored ProviderRegistrar
pahearn73 Jul 14, 2024
f138a80
x-provided-by Pull pattern: Clean-up
pahearn73 Jul 14, 2024
9d2a91a
x-provided-by Pull pattern: Refactored for testability
pahearn73 Jul 14, 2024
f71207f
x-provided-by Pull pattern: Refactored for testability
pahearn73 Jul 14, 2024
7e238c6
x-provided-by Pull pattern: Added unit tests
pahearn73 Jul 15, 2024
5385b41
x-provided-by Pull pattern: Removed debug
pahearn73 Jul 15, 2024
ce32ec3
Merge branch 'main' into pahearn_RPPL-2229
pahearn73 Jul 17, 2024
ef3e756
x-provided-by Pull pattern: Renamed provider map/set --> provider rel…
pahearn73 Jul 17, 2024
8e96069
x-provided-by Pull pattern: Fixed broken tests due to sync
pahearn73 Jul 17, 2024
213bf35
Merge branch 'main' into pahearn_RPPL-2229
pahearn73 Jul 19, 2024
11d2dbc
x-provided-by Pull pattern: Fixed provider response flow
pahearn73 Jul 22, 2024
1e2c182
x-provided-by Pull pattern: Fixed user grant provider invocation
pahearn73 Jul 23, 2024
35cae43
x-provided-by Pull pattern: Bump
pahearn73 Jul 23, 2024
1aa96b9
x-provided-by Pull pattern: Clippy
pahearn73 Jul 23, 2024
d3ece2f
x-provided-by Pull pattern: WIP
pahearn73 Jul 23, 2024
2b68524
x-provided-by Pull pattern: Fixing provider capability mapping
pahearn73 Jul 24, 2024
ca6b19f
x-provided-by Pull pattern: Clippy
pahearn73 Jul 24, 2024
dec157c
x-provided-by Pull pattern: Fixed tests
pahearn73 Jul 24, 2024
f8d9aa0
x-provided-by Pull pattern: Removed debug
pahearn73 Jul 24, 2024
21438b9
x-provided-by Pull pattern: Fixed problem with provider event string …
pahearn73 Jul 24, 2024
6c5f9d5
x-provided-by Pull pattern: Allow availability of discovery:interest …
pahearn73 Jul 24, 2024
1a5c752
Merge branch 'main' into pahearn_RPPL-2229
pahearn73 Jul 24, 2024
9e2d044
x-provided-by Pull pattern: Only process user interest discovery methods
pahearn73 Jul 25, 2024
2564bb4
Merge branch 'main' into pahearn_RPPL-2229
pahearn73 Jul 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/main/src/bootstrap/start_fbgateway_step.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ impl FireboltGatewayStep {
async fn init_handlers(&self, state: PlatformState, extn_methods: Methods) -> Methods {
let mut methods = Methods::new();

// TODO: Ultimately this should be able to register all provider below, for now just does
// AcknowledgeChallenge and PinChallenge.
ProviderRegistrar::register(&state, &mut methods);
// TODO: Ultimately this may be able to register all providers below, for now just does
// those included by build_provider_sets().
ProviderRegistrar::register_methods(&state, &mut methods);

let _ = methods.merge(DeviceRPCProvider::provide_with_alias(state.clone()));
let _ = methods.merge(WifiRPCProvider::provide_with_alias(state.clone()));
Expand Down
4 changes: 2 additions & 2 deletions core/main/src/firebolt/handlers/discovery_rpc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ impl DiscoveryServer for DiscoveryImpl {
&self.state,
FireboltCap::Short(ENTITY_INFO_CAPABILITY.into()).as_str(),
String::from("entityInfo"),
ENTITY_INFO_EVENT,
String::from(ENTITY_INFO_EVENT),
ctx,
request,
)
Expand Down Expand Up @@ -697,7 +697,7 @@ impl DiscoveryServer for DiscoveryImpl {
&self.state,
FireboltCap::Short(PURCHASED_CONTENT_CAPABILITY.into()).as_str(),
String::from("purchasedContent"),
PURCHASED_CONTENT_EVENT,
String::from(PURCHASED_CONTENT_EVENT),
ctx,
request,
)
Expand Down
2 changes: 1 addition & 1 deletion core/main/src/firebolt/handlers/keyboard_rpc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ impl KeyboardImpl {
&self.platform_state,
String::from(KEYBOARD_PROVIDER_CAPABILITY),
method,
event_name,
String::from(event_name),
ctx,
request,
)
Expand Down
4 changes: 2 additions & 2 deletions core/main/src/firebolt/handlers/lcm_rpc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -113,15 +113,15 @@ impl LifecycleManagementImpl {
&self.state,
FireboltCap::short("app:lifecycle").as_str(),
method.into(),
event_name,
String::from(event_name),
ctx,
request,
)
.await;

Ok(ListenerResponse {
listening: listen,
event: event_name.into(),
event: String::from(event_name),
})
}
}
Expand Down
2 changes: 1 addition & 1 deletion core/main/src/firebolt/handlers/localization_rpc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ impl LocalizationImpl {
// TODO update with Firebolt Cap in later effort
"xrn:firebolt:capability:localization:locale".into(),
method.into(),
event_name,
String::from(event_name),
ctx,
request,
)
Expand Down
Loading
Loading