Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPPL-2148 [Storage Broker] Cleanup Localization #568

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

Conversation

sakshihcst
Copy link
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@sakshihcst sakshihcst requested a review from satlead July 15, 2024 22:11
@sakshihcst sakshihcst requested a review from a team July 15, 2024 22:30
@CLAassistant
Copy link

CLAassistant commented Jul 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Vinodsathyaseelan Vinodsathyaseelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage of main_internal_request() call for localization.language from LoadDistributorValuesStep::setup() -> MetricsState::initialize() will cause bootstrap lock up (indefinite wait). Covert this PR to draft for re-work.

@sakshihcst sakshihcst requested review from Vinodsathyaseelan and a team July 29, 2024 18:13
Copy link

github-actions bot commented Aug 5, 2024

Code Coverage

Package Line Rate Health
distributor.general.src 2%
core.main.src.bootstrap.manifest 0%
core.main.src.bootstrap 0%
core.sdk.src.api 78%
core.main.src.service.apps 47%
core.sdk.src.api.device 77%
core.main.src.firebolt.handlers 8%
core.main.src.state 25%
core.sdk.src.api.firebolt 78%
core.main.src 0%
core.main.src.service.extn 40%
device.thunder.src.bootstrap 0%
core.main.src.broker.thunder 54%
core.sdk.src.api.gateway 87%
core.sdk.src.framework 75%
device.thunder_ripple_sdk.src.processors 10%
device.thunder_ripple_sdk.src.events 4%
core.sdk.src.api.manifest 91%
core.tdk.src.utils 0%
core.main.src.processor 0%
core.launcher.src.manager 7%
core.sdk.src.utils 53%
core.main.src.firebolt 4%
core.main.src.bootstrap.extn 0%
core.main.src.service 31%
openrpc_validator.src 90%
core.sdk.src.api.observability 68%
core.sdk.src.api.distributor 84%
core.sdk.src.extn.ffi 80%
core.tdk.src.gateway 100%
device.mock_device.src 52%
device.thunder.src 0%
core.main.src.utils 29%
core.main.src.state.cap 44%
core.launcher.src 0%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src.processor.storage 0%
core.sdk.src.extn 83%
device.thunder_ripple_sdk.src.bootstrap 0%
core.main.src.broker 38%
device.thunder_ripple_sdk.src 15%
device.thunder_ripple_sdk.src.client 74%
core.sdk.src.extn.client 91%
Summary 43% (17718 / 40805)

Minimum allowed line rate is 42%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants