Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Filtering logs #570

Merged
merged 5 commits into from
Jul 25, 2024
Merged

refactor: Filtering logs #570

merged 5 commits into from
Jul 25, 2024

Conversation

nnaveen979
Copy link
Contributor

@nnaveen979 nnaveen979 commented Jul 16, 2024

What

added the log filter based on crate names like h2, hyper, tower, tower_http, rustls, jsonrpsee_client_transport, jsonrpsee_core with the log level as OFF

Why

to cutdown the unnecessary log capturing in the production build

How

apply log level filter using the crate names and mention log level as OFF

Test

run the bootup sequence and checked the logs before and after these changes.

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@nnaveen979 nnaveen979 requested review from brendanobra, satlead and a team July 16, 2024 08:03
@CLAassistant
Copy link

CLAassistant commented Jul 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Code Coverage

Package Line Rate Health
core.sdk.src.api.manifest 91%
core.main.src.firebolt 1%
core.main.src.bootstrap 0%
core.main.src.bootstrap.manifest 0%
core.sdk.src.api.distributor 84%
core.main.src.broker.thunder 54%
core.launcher.src 0%
core.main.src.processor 0%
device.thunder.src 0%
core.main.src.state.cap 44%
core.tdk.src.utils 0%
device.thunder_ripple_sdk.src.client 74%
core.sdk.src.api 78%
core.sdk.src.extn.ffi 80%
core.main.src.utils 29%
core.sdk.src.api.firebolt 78%
core.sdk.src.extn.client 91%
core.sdk.src.api.gateway 87%
openrpc_validator.src 90%
core.main.src.broker 35%
core.main.src.processor.storage 0%
core.main.src.firebolt.handlers 1%
core.main.src.service.extn 40%
device.thunder_ripple_sdk.src 15%
core.main.src.service 31%
core.main.src 0%
core.main.src.bootstrap.extn 0%
core.main.src.state 22%
core.main.src.service.apps 47%
device.thunder.src.bootstrap 0%
device.mock_device.src 52%
core.tdk.src.gateway 100%
device.thunder_ripple_sdk.src.processors.events 0%
core.sdk.src.api.device 77%
device.thunder_ripple_sdk.src.processors 10%
core.sdk.src.framework 75%
core.sdk.src.utils 53%
device.thunder_ripple_sdk.src.events 4%
core.sdk.src.api.observability 68%
core.sdk.src.extn 83%
distributor.general.src 2%
device.thunder_ripple_sdk.src.bootstrap 0%
core.launcher.src.manager 7%
Summary 43% (17191 / 40055)

Minimum allowed line rate is 41%

@nnaveen979 nnaveen979 merged commit 8cf00de into main Jul 25, 2024
8 checks passed
@nnaveen979 nnaveen979 deleted the RPPL-1679_log_filter branch July 25, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants