Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed startmode from Plugin State Status structure #573

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Vinodsathyaseelan
Copy link
Contributor

@Vinodsathyaseelan Vinodsathyaseelan commented Jul 16, 2024

What

Removed unused startmode filed from PluginStatus response.

Why

It's an optional field and currently not used in Ripple. This was causing a deserialization error in parsing Status response from Controller as not all plugin status response includes startmode in the response message

How

Removed this field from Status structure.

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Code Coverage

Package Line Rate Health
core.main.src.processor.storage 0%
core.main.src.utils 29%
device.thunder.src 0%
core.main.src.state 22%
core.main.src.broker 35%
core.sdk.src.api 78%
device.mock_device.src 52%
core.main.src.firebolt.handlers 1%
core.main.src.service.apps 47%
device.thunder_ripple_sdk.src.bootstrap 0%
device.thunder_ripple_sdk.src.processors 10%
core.sdk.src.utils 53%
core.tdk.src.gateway 100%
core.main.src.service 31%
core.sdk.src.api.device 77%
device.thunder_ripple_sdk.src.events 4%
core.sdk.src.extn.ffi 80%
core.launcher.src 0%
core.main.src.bootstrap.extn 0%
core.main.src.state.cap 44%
core.sdk.src.api.manifest 91%
core.main.src.bootstrap.manifest 0%
core.sdk.src.extn 83%
core.main.src.processor 0%
openrpc_validator.src 90%
core.main.src.bootstrap 0%
device.thunder.src.bootstrap 0%
device.thunder_ripple_sdk.src.client 74%
distributor.general.src 2%
core.launcher.src.manager 7%
core.sdk.src.framework 75%
core.sdk.src.api.distributor 84%
core.main.src.firebolt 1%
core.tdk.src.utils 0%
core.sdk.src.extn.client 91%
core.sdk.src.api.observability 68%
core.main.src.service.extn 40%
core.sdk.src.api.firebolt 78%
device.thunder_ripple_sdk.src.processors.events 0%
device.thunder_ripple_sdk.src 15%
core.main.src.broker.thunder 55%
core.main.src 0%
core.sdk.src.api.gateway 87%
Summary 43% (17186 / 40033)

Minimum allowed line rate is 41%

@Vinodsathyaseelan Vinodsathyaseelan merged commit 240c2b3 into main Jul 16, 2024
8 checks passed
@Vinodsathyaseelan Vinodsathyaseelan deleted the RPPL-2132-patch branch July 16, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants