Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create JQ rule for TextTrack Plugin #597

Merged
merged 31 commits into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
623100f
fix endpoint broker apply response parse json rpc response
maggie98choy Aug 7, 2024
77da20c
parse and apply jq rule on error response
maggie98choy Aug 7, 2024
9283b5c
update code
maggie98choy Aug 8, 2024
b8120ab
update code
maggie98choy Aug 8, 2024
b0e9d92
update code
maggie98choy Aug 8, 2024
61ea1c5
add more unit test
maggie98choy Aug 9, 2024
8db9358
feat: Create JQ rule for TextTrack Plugin
Vinodsathyaseelan Aug 5, 2024
c2af58a
build: Merge branch 'main' into RPPL-2138
Vinodsathyaseelan Aug 9, 2024
84b1f7a
build: Merge branch 'fix-apply-response-parse-valid-json-rpc-response…
Vinodsathyaseelan Aug 9, 2024
8ff5318
fix endpoint broker apply response parse json rpc response
maggie98choy Aug 7, 2024
2b239cf
parse and apply jq rule on error response
maggie98choy Aug 7, 2024
c932085
update code
maggie98choy Aug 8, 2024
9442530
update code
maggie98choy Aug 8, 2024
56ab651
update code
maggie98choy Aug 8, 2024
d37d201
add more unit test
maggie98choy Aug 9, 2024
afb7e50
update unit test
maggie98choy Aug 9, 2024
7ee3428
update unit test
maggie98choy Aug 9, 2024
f86a9b6
add more unit test
maggie98choy Aug 12, 2024
94caea0
fix formating error
maggie98choy Aug 12, 2024
8ba47f1
build: Merge branch 'main' into RPPL-2138
Vinodsathyaseelan Aug 12, 2024
305511b
build: Merge branch 'fix-apply-response-parse-valid-json-rpc-response…
Vinodsathyaseelan Aug 13, 2024
61e5ab0
build: Merge branch 'main' into RPPL-2138
Vinodsathyaseelan Aug 13, 2024
7a194f6
build: Merge branch 'main' into RPPL-2138
Vinodsathyaseelan Aug 19, 2024
c1e18e2
build: Merge branch 'main' into RPPL-2138
Vinodsathyaseelan Sep 3, 2024
42c9f60
build: Merge branch 'main' into RPPL-2138
Vinodsathyaseelan Sep 4, 2024
3721dfc
fix: when both result & error are null & no rule
SKumarMetro Sep 5, 2024
dc7beab
build: Merge branch 'main' into RPPL-2138
Vinodsathyaseelan Sep 5, 2024
590fa8b
fix: clippy error
SKumarMetro Sep 5, 2024
4f0e986
Merge branch 'RPPL-2138' of https://github.com/rdkcentral/Ripple into…
SKumarMetro Sep 5, 2024
afcdb8f
build: Merge branch 'main' into RPPL-2138
Vinodsathyaseelan Sep 16, 2024
8ad084d
build: Merge branch 'RPPL-2138' of https://github.com/rdkcentral/Ripp…
Vinodsathyaseelan Sep 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/main/src/broker/endpoint_broker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,8 @@ impl BrokerOutputForwarder {
super::rules_engine::RuleTransformType::Response,
) {
apply_response(filter, &rpc_request, &mut response);
} else if response.result.is_none() && response.error.is_none() {
response.result = Some(Value::Null);
}
}

Expand Down
7 changes: 3 additions & 4 deletions core/main/src/broker/thunder/thunder_plugins_status_mgr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const DEFAULT_PLUGIN_ACTIVATION_TIMEOUT: i64 = 8;
// But it didn't work, most probably a documentation issue.
// const STATE_CHANGE_EVENT_METHOD: &str = "client.events.1.statechange";

const STATE_CHANGE_EVENT_METHOD: &str = "client.Controller.1.events.statechange";
const STATE_CHANGE_EVENT_METHOD: &str = "thunder.Broker.Controller.events.statechange";

#[derive(Debug, Deserialize, PartialEq, Serialize, Clone)]
pub struct Status {
Expand Down Expand Up @@ -271,7 +271,7 @@ impl StatusManager {
"method": format!("{}register", controller_call_sign),
"params": json!({
"event": "statechange",
"id": "client.Controller.1.events"
"id": "thunder.Broker.Controller.events"
})
})
.to_string();
Expand Down Expand Up @@ -330,8 +330,7 @@ impl StatusManager {
}
}

// return false from here so that other subscribers can also process the response
return false;
return true;
}
}

Expand Down
Loading