Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configurable Provider Registrations #599

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Conversation

satlead
Copy link
Collaborator

@satlead satlead commented Aug 9, 2024

What

Provider registrations are hard coded in ripple, making it configurable.

Why

Hard coded configurations are not scalable for extension sdks.

How

Having a default set of configurations and allow it to be overridden by manifests

Test

Test without any manifest changes and make sure all the provider pattern works
Add an entry in provider_registrations for extension manifest and check if other providers fail with method not found.

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

Copy link

Code Coverage

Package Line Rate Health
core.main.src.processor.storage 0%
core.main.src.bootstrap 0%
device.thunder.src 0%
device.thunder_ripple_sdk.src.bootstrap 0%
core.tdk.src.gateway 100%
core.main.src.service.apps 47%
device.thunder_ripple_sdk.src 15%
distributor.general.src 2%
core.launcher.src.manager 7%
core.sdk.src.utils 53%
core.sdk.src.api.observability 68%
core.main.src.bootstrap.extn 0%
core.main.src.firebolt 4%
device.thunder.src.bootstrap 0%
core.main.src.broker.thunder 54%
core.main.src.state 26%
core.sdk.src.api.firebolt 78%
device.mock_device.src 52%
core.main.src 0%
core.main.src.state.cap 44%
core.main.src.service 31%
core.sdk.src.api.device 77%
core.sdk.src.extn.ffi 80%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src.broker 44%
core.main.src.processor 0%
core.tdk.src.utils 0%
device.thunder_ripple_sdk.src.processors 10%
core.main.src.utils 29%
openrpc_validator.src 90%
core.main.src.bootstrap.manifest 0%
core.sdk.src.extn 83%
core.launcher.src 0%
device.thunder_ripple_sdk.src.events 4%
core.main.src.service.extn 40%
core.sdk.src.framework 75%
core.main.src.firebolt.handlers 8%
core.sdk.src.api 78%
device.thunder_ripple_sdk.src.client 74%
core.sdk.src.extn.client 91%
core.sdk.src.api.distributor 84%
core.sdk.src.api.gateway 87%
core.sdk.src.api.manifest 91%
Summary 44% (17930 / 41035)

Minimum allowed line rate is 42%

@satlead satlead merged commit 569a8e1 into main Aug 23, 2024
7 checks passed
@satlead satlead deleted the provider-config-update branch August 23, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants