-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support to ingest supported with roles #601
add support to ingest supported with roles #601
Conversation
d3643a2
to
5b01dfa
Compare
@@ -225,7 +225,7 @@ impl Serialize for FireboltPermission { | |||
{ | |||
let s = self.cap.as_str(); | |||
let suffix = match self.role { | |||
CapabilityRole::Use => "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably should not be removed
let mut perm_list: Vec<FireboltPermission> = Vec::new(); | ||
for perm in perm_strings { | ||
if role_based_support { | ||
let pattern = r"^xrn:firebolt:capability:([a-z0-9\\-]+)((:[a-z0-9\\-]+)?)$"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use serde_json::from_str::()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix unsafe unwraps
fce2172
to
0915708
Compare
0915708
to
49b0c0b
Compare
c0b0ef1
to
73c1526
Compare
Minimum allowed line rate is |
What
What does this PR add or remove?
Why
Why are these changes needed?
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist