Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: http_broker bugfixes #606

Merged
merged 6 commits into from
Aug 26, 2024
Merged

fixes: http_broker bugfixes #606

merged 6 commits into from
Aug 26, 2024

Conversation

brendanobra
Copy link
Contributor

@brendanobra brendanobra commented Aug 20, 2024

What

for http_broker:

  1. fixed bugs that were 1) not using uri in config 2) only support POST (it now only supports GET, which is all that is needed presently) 3) not using the rules engine 4) general refactor to be a bit more idiomatic/readable

Why

http_broker was not working

How

fixes/improvements implemented

Test

Tested against hw

Checklist

  • [ x] I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective
    (unit tests will follow time permitting)

Copy link

Code Coverage

Package Line Rate Health
core.sdk.src.utils 53%
core.main.src.firebolt.handlers 8%
core.sdk.src.framework 75%
core.tdk.src.utils 0%
core.main.src.bootstrap.extn 0%
core.main.src.service.apps 47%
core.main.src.processor.storage 0%
core.main.src.broker 43%
core.main.src.service.extn 40%
core.main.src.broker.thunder 54%
core.main.src.service 31%
core.main.src 0%
core.sdk.src.api 78%
core.sdk.src.api.device 77%
core.sdk.src.api.firebolt 78%
core.sdk.src.api.observability 68%
device.thunder.src.bootstrap 0%
core.sdk.src.api.gateway 85%
device.thunder_ripple_sdk.src.client 74%
core.sdk.src.api.distributor 84%
core.main.src.bootstrap.manifest 0%
core.tdk.src.gateway 100%
core.main.src.bootstrap 0%
core.sdk.src.extn 83%
device.thunder.src 0%
core.main.src.utils 29%
device.mock_device.src 52%
device.thunder_ripple_sdk.src.events 4%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src.state 26%
core.sdk.src.extn.ffi 80%
core.main.src.processor 0%
core.main.src.firebolt 4%
core.main.src.state.cap 44%
device.thunder_ripple_sdk.src.processors 10%
device.thunder_ripple_sdk.src 15%
distributor.general.src 2%
openrpc_validator.src 90%
core.launcher.src.manager 7%
core.sdk.src.extn.client 91%
core.launcher.src 0%
core.sdk.src.api.manifest 91%
device.thunder_ripple_sdk.src.bootstrap 0%
Summary 44% (17930 / 41116)

Minimum allowed line rate is 42%

@brendanobra brendanobra merged commit 465e394 into main Aug 26, 2024
7 checks passed
@brendanobra brendanobra deleted the fix/http_broker_improvements branch August 26, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants